Rich Burridge wrote:

>  http://cr.opensolaris.org/~richb/pkg-2217-v1/

I think for packages which are updating or introducing new driver actions,
we should have new files in the build 125 directory, which you indicate is
what's actually going on in your workspace.  However, for files which have
simply had their formatting changed, they shouldn't be copied.

You don't mention much about devlink.tab, though I see you added at least
one entry for it into a new action.  Should that be dropped, too, and have
its "empty" file delivered?

SUNWmd: the two driver actions look identical; why have separate sparc and
x86 declarations?

SUNWldom: what happened to cnex and drctl?

SUNWssad: for consistency, put quotes around the first alias value.

SUNWmv88sx: could you sort the aliases?

I took a quick look at the attachments to 2217 to swee what difference
you've found.  I assume a bunch of these are due to non-redistributable
drivers, which makes sense.  But where are the extra entries coming from?
And things like tpm in driver_aliases on sun4v looks like it's wrong (no
quotes?).  And there are some drivers that you're saying are missing, but,
I think, shouldn't be (clone, nge, rtls).  And is the fact that ata is,
normally, in both scsi and dada classes, but isn't on the opensolaris
image, a problem?

Thanks,
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to