Padraig,
Thanks for all the comments.
New webrev:
http://cr.opensolaris.org/~migi/11670_v2/
Please note that there is also change in the src/pkgdefs/SUNWipkg/prototype.
This is due to bug which breaks build of the gate. This fix will not be
included in the push to the gate, but it allows you to build the gate.
enumerations.py:
At line 109 "Package Sources" should be "Publishers"
Changed.
progress.py:
You output message in cat_output_start, cache_cats_output_start and
load_cat_cache_output_start but do not output anything in
corresponding _done function. Will another message be output for the
next operation so that the user will not be under the misapprehension
that an operation is taking longer than it is.
No, the done functions are needed for the CLI to flush whatever is in
the buffer to the terminal screen.
If operation is done, it goes straight to another one, so IMHO it would
be also duplication of the information and too much noise.
repository.py:
I thought that the convention for statements which exceed one line was
that each continuation line was indented 4 spaces from original line.
This is not so at lines 87, 102, 106, 108, 110, 112, 127, 129, 131,
133, 164, 167, 170, 173, 176, 179, 195, 197.
Fixed, also there were 8 spaces in few other places such as dictionary
with signals.
Is there a bug logged for reference to BUG at line 431?
Thanks for loggin one:
http://defect.opensolaris.org/bz/show_bug.cgi?id=11715
Is there a bug or RFE logged about XXX at line 655?
Because we don't have publisher API yet, I had to copy this line from
the client.py. This information was there. I have changed it now to:
# This part is copied from "def
publisher_set(img, args)"
# from the client.py as the publisher API is not
ready yet.
Are you fine with this?
In __add_repository there is a message output to the details panel
before and after the operation.
I have added this in the __update_publisher as this is called from
__add_repository.
In __update_publisher there is a message output to the details panel
before the operation but none after the operation. Similarly when
removing or updating a publisher in __proceed_after_confirmation.
It's added to both functions.
Should Modify Publisher and Modify Repository dialogs have Help button?
Added.
Lines 790, 791, 794-798 are commented out. Should they be removed?
Removed.
There is a TODO at line 1088.
Fixed.
best
Michal
Padraig
On 10/01/09 16:59, Michal Pryc wrote:
Hello,
The webrev is at:
http://cr.opensolaris.org/~migi/11670_v1/
Please note that some of the dialogs may differ from the wireframes
due to lack of publisher API. This includes:
Manage Publishers dialog:
- lack of publisher priorities
- lack of publisher status information (offline/online/etc...)
- extra Preffered column which is read-only
- in most cases the description is missing from the Details field (it
is there when the publisher was added using p5i file containing desc)
Modify Publisher dialog:
- repository doesn't have registration field (it's always n/a)
- can have only one repository per publisher, so there is always one
Active repository
Add Publisher:
- extra field "Name"
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
