Joanmarie,
Thanks for testing this:
http://cr.opensolaris.org/~migi/11670_v4
Fixes the problem you are describing.
best
Michal
Joanmarie Diggs wrote:
Michal, thanks so much for taking the time to look at all those mnemonic
widgets. I just did a quick check with Orca and everything looks right
with one exception:
+ <widget class="GtkLabel" id="label35">
+ <property name="visible">True</property>
+ <property name="xalign">0</property>
+ <property name="yalign">0</property>
+ <property name="ypad">4</property>
+ <property name="label" translatable="yes">SSL
_Certificate:</property>
+ <property name="use_underline">True</property>
+ </widget>
Please add a mnemonic widget pointing to modcertentry.
Take care.
--joanie
On Tue, 2009-10-06 at 13:06 +0100, Michal Pryc wrote:
Padraig, Joanmarie,
New webrev:
http://cr.opensolaris.org/~migi/11670_v4
Please find my comments inline.
Follow on from Joanie's mail:
1) There should be no mnemonic_widget for all_pub_label.
It's not in the webrev.
2) What is the purpose of specifying invisible_char in GtkEntry
widgets. Some examples are add_puiblisher_name and add_publisher_url.
It's:
"The character to use when masking entry contents ("in password mode")"
So we are not using it and we can ignore the existence of it, but by
default it's created as * together with new entry widget.
3) add_publisher_url should be mnemonic_widget for url_label
Added.
4) In Modify Publisher dialog modify_pub_url should be mnemonic_widget
for modlabel1.
Added.
5) In Modify Repository dialog for label24 _Name should be Name� and
it should not have mnemonic_widget.
Changed.
6) In Modify Repository dialog label35 should have mod_cert_entry as
mnemonic_widget.
It does have mnemonic_widget, but different one:
modcertentry for label35
modkeyentry for label34
I am pretty sure that thsoe are correct.
7) In Modify Repository dialog add_mirror_entry should be mnemonic
widget for label36.
It is there.
Should self.publisher_info at line 72 of repository.py be a translatable
string?
Changed
Padraig
On 10/05/09 16:03, Joanmarie Diggs wrote:
I've got another. :-)
Each label should have a mnemonic_widget property pointing to the
GtkEntry it labels. (This will cause an accessible LABELLED_BY
relationship to be set on the entry, which in turn causes Orca to speak
and braille the label of the field when it's given focus.)
I've added (I think) all of those. Thanks a lot for pointing this out.
Also, it looks like two labels have a mnemonic widget property pointing
to add_publisher_name: add_pub_label and name_label. It should only be
set for name_label as the former is serving as static text. (Plus,
apparently, having it set in both places causes the accessible
relationship to be set in neither. Go figure....)
Changed, now only one have mnemonic.
--
best
Michal
Thanks. Take care.
--joanie
On Mon, 2009-10-05 at 15:47 +0100, Padraig O'Briain wrote:
Just one more comment:
Should self.publisher_info at line 72 of repository.py be a translatable
string?
Padraig
On 10/05/09 14:47, Michal Pryc wrote:
Padraig,
Thanks for all the comments.
New webrev:
http://cr.opensolaris.org/~migi/11670_v2/
Please note that there is also change in the
src/pkgdefs/SUNWipkg/prototype.
This is due to bug which breaks build of the gate. This fix will not
be included in the push to the gate, but it allows you to build the gate.
enumerations.py:
At line 109 "Package Sources" should be "Publishers"
Changed.
progress.py:
You output message in cat_output_start, cache_cats_output_start and
load_cat_cache_output_start but do not output anything in
corresponding _done function. Will another message be output for the
next operation so that the user will not be under the misapprehension
that an operation is taking longer than it is.
No, the done functions are needed for the CLI to flush whatever is in
the buffer to the terminal screen.
If operation is done, it goes straight to another one, so IMHO it
would be also duplication of the information and too much noise.
repository.py:
I thought that the convention for statements which exceed one line
was that each continuation line was indented 4 spaces from original
line.
This is not so at lines 87, 102, 106, 108, 110, 112, 127, 129, 131,
133, 164, 167, 170, 173, 176, 179, 195, 197.
Fixed, also there were 8 spaces in few other places such as dictionary
with signals.
Is there a bug logged for reference to BUG at line 431?
Thanks for loggin one:
http://defect.opensolaris.org/bz/show_bug.cgi?id=11715
Is there a bug or RFE logged about XXX at line 655?
Because we don't have publisher API yet, I had to copy this line from
the client.py. This information was there. I have changed it now to:
# This part is copied from "def
publisher_set(img, args)"
# from the client.py as the publisher API is
not ready yet.
Are you fine with this?
In __add_repository there is a message output to the details panel
before and after the operation.
I have added this in the __update_publisher as this is called from
__add_repository.
In __update_publisher there is a message output to the details panel
before the operation but none after the operation. Similarly when
removing or updating a publisher in __proceed_after_confirmation.
It's added to both functions.
Should Modify Publisher and Modify Repository dialogs have Help button?
Added.
Lines 790, 791, 794-798 are commented out. Should they be removed?
Removed.
There is a TODO at line 1088.
Fixed.
best
Michal
Padraig
On 10/01/09 16:59, Michal Pryc wrote:
Hello,
The webrev is at:
http://cr.opensolaris.org/~migi/11670_v1/
Please note that some of the dialogs may differ from the wireframes
due to lack of publisher API. This includes:
Manage Publishers dialog:
- lack of publisher priorities
- lack of publisher status information (offline/online/etc...)
- extra Preffered column which is read-only
- in most cases the description is missing from the Details field
(it is there when the publisher was added using p5i file containing
desc)
Modify Publisher dialog:
- repository doesn't have registration field (it's always n/a)
- can have only one repository per publisher, so there is always one
Active repository
Add Publisher:
- extra field "Name"
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
