Thanks for the feedback Padraig comments below and new webrev (includes fixes for Michal's comment):

webrev: http://cr.opensolaris.org/~jmr/pm_enhance_search_ui_11669_05Oct_535pm/ bug: 11669 Enhance handling of Search All Publishers to match current UI Spec
bug: 11699 Missing focus rectangle and missing a11y events on PM start page

JR


Padraig O'Briain wrote:
Consider the following:

- Switch to All Publishers
Page is displayed as expected

- Search for *
Page is displayed as expected

- Clear search text and results
No page is displayed.

Is this the intended behavior?
Nope - when in All Publishers should display the Page on clearing search, now does

Should you be using stock icons for dialog-information and dialog-warning?
The icons need to be in the startpagebase/<locale>/ dir from which the start page is initially loaded. When the startpage is loaded it sets up the path the GtkHTML widget uses to find any images referenced from pages it loads.

We can change them as part of what we deliver into the startpage dir. They are delivered as part of SUNWipkg-gui-data and so are not meant to be themeable.
If not, should these icons be themable and be in SUNWipkg package?

packagemanager.py:

At line 962 makes, what looks to me like unwarrented assumptions about
how a string will be translated.
Fine - changed to be more robust.

There are extra spaces at line 2012.

Do I understand correctly that you have removed the timing information from the statusbar after a search?
Yes this was for debug and Ann wanted it removed. Also it now appears that search tiings are fine and the slow down we still see is due to an infrastructural issue due to the lack of a full mirror in Eurpoe. Reviewing status bar information I have put back the information on which publisher you are searching as I found it useful. Will see if Ann wants this or not.

JR

Padraig


On 10/02/09 15:27, jmr wrote:
Michal - here is a respin:

webrev: http://cr.opensolaris.org/~jmr/pm_enhance_search_ui_11669_02Oct_320pm/ bug: 11669 Enhance handling of Search All Publishers to match current UI Spec

I had to rework things a bit to take account of the fact that you can now save the last Publisher on shutdown and restore on startup. This requires special handling for All Publishers. I also added Jyothi's request to allow you to have a browse link from the Search All Publishers page. This might address the following bug, it certainly gives you a fast startup and easy access to browsing the Publishers if you wish: 11646 Restoring All Publisher should also restore last viewed publisher categories

JR

Michal Pryc wrote:
John,
I can see in many places html code with some strings not being translated _().
Is it intentional ?

best
Michal

jmr wrote:
Hi here is a webrev to update some of PM's search behavior, in particular when switching into All Publishers and when zero results are returned. This was driven by feedback from the usability studies.

webrev: http://cr.opensolaris.org/~jmr/pm_enhance_search_ui_11669_01Oct_510pm/ bug: 11669 Enhance handling of Search All Publishers to match current UI Spec

JR

From the bug:

When we switch into the All Publishers view currently the user sees an empty list, same is true if zero results are returned for All Publishers or any
Publisher. Change to match the spec are as follows:

- Switching to All Publishers, display a page in the List view location giving
users some help about the mode they are in.

- Searching in a publisher that returns zero results, display a page giving them some help. Also allow them to re-excute the search in All Publishers from
this page.

- Searching in All Publisher that returns zero results, display a page giving
them some help.
- Searching using * in All Publishers is not supported, display a page
explaining this to the user.


_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss


_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to