[email protected] wrote:
I'd appreciate a review of the following modified webrev

    http://cr.opensolaris.org/~comay/webrev-6482/

that covers changes for the following set of issues

I've now looked at the rest of it.

Just one very minor nit and a question:

* Is there a reason why the entries in minor_perm.i386
 and minor_perm.sparc can't be sorted by driver name
 rather than keeping them in major device number order?

* I can now see that the minor_perm files for Nevada build #124
 have two entries each for the e1000g driver:

 intel/minor_perm:e1000g:* 0666 root sys
 intel/minor_perm:e1000g:* 0666 root root

 sparc-sun4v/minor_perm:e1000g:* 0666 root sys
 sparc-sun4v/minor_perm:e1000g:* 0666 root root

 sparc/minor_perm:e1000g:* 0666 root sys
 sparc/minor_perm:e1000g:* 0666 root root

 I take it from your change to .../125/common/SUNWintgige
 that 'perms="* 0666 root sys"' is the correct one?

_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to