Webrev: http://cr.opensolaris.org/~bpytlik/ips-11805-v1/
Bugs: 11805 pkgdep generate doesn't respect the payload path for file actions 11773 ldtp can't make connection (thus can't run test suite) This includes the fix for 11773 because without it I can't run the tests. In summary, there are really three types of file actions. The classic file actions which no nothing about payloads. These are the file actions all the code is familiar with except for pkgsend and pkgdep. pkgsend and pkgdep both need file actions which know about payloads and paths to payloads. Finally, pkgdep needs file actions which also remember the local path to the payload so that things like elf dump and python's module finder can be used. The suggested fix for this bug takes all those issues into account. It creates a central location where payloads and paths to payloads are handled (since there was also inconsistency with what pkgsend add and pkgsend include could handle) and places the functions (internalizestr and internallist) in pkg.actions.__init__ alongside fromstr. (Both internalize functions are needed unless we choose to want to emulate shell quoting and argument splitting rules because in pkgsend add, the action is passed as part of the command line and is processed by the shell.) Those functions return the action with the payload set, and the local path to the payload. pkgsend ignores the local path information but pkgdep places it in a special attribute of the action reserved for this purpose. pkgdep is careful to endure that the local path information never appears in a manifest it produces. Brock _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
