Brock Pytlik wrote:
> http://cr.opensolaris.org/~bpytlik/ips-11805-v1/
__init__.py:
- line 181, 258: "function"
- line 192: bad grammar. "is a list of the directories ..." at a
minimum?
- line 206: I think "del args[0]" is probably faster, though you could
simply do "data = args.pop(0)"
- I don't understand why you haven't simply enhanced fromstr() and
fromlist() to take the optional basedirs and load_data arguments.
script.py:
- line 75: can now take proto_dir
manifest.py:
- this functionality is really useful, but I'd like to see it implemented
differently -- drop actions_set_content(), but allow the "content"
parameter to set_content() to have multiple types. You'll probably
want to keep __add_action(), and just have set_content() call it
repeatedly based either on the list of actions or on the output of the
calls to fromstr(). You may or may not want to put the splitlines()
loop into its own private generator function.
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
