Hey Shawn,
On Thu, Oct 15, 2009 at 05:36:45PM -0500, Shawn Walker wrote:
> webrev
> http://cr.opensolaris.org/~swalker/pkg-cat-p3/
I took a pass through this while some of my tests were running for
Quality.
I found a few nits, but nothing major. They are in my code. (sorry)
depot.py:
- lines 207, 317, 329, 330, 332, 673, 675: s/ign_ops/dis_ops/ ?
- might also want to s/ignorestrs/disablestrs/ on 313, 315, and 318
client/transport/transport.py:
- lines 301, 302: This value error should use parens. I was unaware
of this until you pointed it out in a different code review.
server/depot.py:
- I thought I fixed this everywhere, but I guess I only fixed this in
depot.py. It looks like this file also needs
s/ignore_ops/disable_ops/ on 114, 153, 154/
-j
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
