On Tue, Oct 20, 2009 at 10:25:58AM -0700, Danek Duvall wrote: > > http://cr.opensolaris.org/~swalker/pkg-cat-p3/
> transport.py: > > - line 376: Why this test? The client has to compute the succesful requests if failures occurred. Otherwise, all requests are assumed to have succeeded. > - line 377: success = [ x for x in flist if x not in failedreqs ] ? What's wrong with filter? > - line 414: > > if failedreqs and failures: > failures = [ x for for x in failures if x.request in failedreqs ] > tfailurex = tx.TransportFailures() > tfailurex += failures > raise tfailurex The TransportFailures object coalesces re-occuring errors. I don't believe that the += is going to work. -j _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
