John Sonnenschein wrote:
So testing in a meaningful way is proving to be difficult. I'm not sure
exactly how to verify the size of transient files deterministically. If
anyone has any better ideas pipe up but for now I've simply omitted the
tests ( since the ones I had were, as Shawn pointed out, not terribly
helpful).
That said, I believe I've addressed the other CR comments, webrev here:
http://cr.opensolaris.org/~error404/7360_2/
These are pedantic mostly.
src/depot.py:
line 133: this option needs to swap places with --writable-root
line 176: indentation is off by one
line 266: please put the sort-file-max-size option before
writable-root :)
lines 407-411: move to before --writable-root
line 642: move to before writable_root
modules/indexer.py:
line 70: missing spaces around '='
modules/server/repository.py:
line 174: move option before writable_root
line 188: missing spaces around '='
Cheers,
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
