John Sonnenschein wrote:
All of Shawn's concerns are taken care of, and I've got some tests
working as well.
Changeset here: http://cr.opensolaris.org/~error404/7360_4/
LGTM Thanks for adding those test cases.
Brock
Thanks very much for the eyes
-JohnS
Brock Pytlik wrote:
John Sonnenschein wrote:
So testing in a meaningful way is proving to be difficult. I'm not
sure exactly how to verify the size of transient files
deterministically. If anyone has any better ideas pipe up but for
now I've simply omitted the tests ( since the ones I had were, as
Shawn pointed out, not terribly helpful).
That said, I believe I've addressed the other CR comments, webrev
here: http://cr.opensolaris.org/~error404/7360_2/
-JohnS
The way to do the testing I think is to make an api test and call the
_add_terms function of the indexer directly. That provides the right
granularity of control so that you can check whether a new file has
been created at the right time.
Brock
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
