Hey all,

I'd like review for:
    #11609 ignoring .SUNW_ctf in elfhashing may cause type resolution
           weirdness

Webrev:
    http://cr.opensolaris.org/~richlowe/pkg_11609

The important change is the removal of .SUNW_ctf from the list of
excluded sections in elfextract.c:hashsection, other changes are
cstyling and moving of the comment related to elf hashing to near the
code that implements it.

Tested via repeated upgrade of on_ips bits with patched and unpatched
pkg, and comparison of files changed, also via running elf.get_dynamic()
on the most recently problem files:

    % what fct_*
    fct_125:
            SunOS 5.11 snv_125 November 2008
    fct_126:
            SunOS 5.11 snv_126 November 2008

    % python testy.py fct_*
    93d33447f7c94b8c9f229214b30b0df06aaea2e3
    93d33447f7c94b8c9f229214b30b0df06aaea2e3

    % PYTHONPATH=$ROOT/usr/lib/python2.4/vendor-packages python testy.py fct_*
    23df84f80fc4c2ce570e7538606a0eecb98cde31
    719c9868919aaebe600aa70ab369e5416287e461 

Where testy.py is:
    import sys
    from pkg import elf

    for elt in sys.argv[1:]:
        print elf.get_dynamic(elt)["hash"]

Thanks, 

-- Rich
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to