Danek Duvall wrote:
But please do take a closer look to see if there's anything that doesn't make sense to you.
Looking closer, I can't find anything that I can say with certainty is wrong. Although I did notice it uses a rather simplistic algorithm for trimming the filenames in the report, so 'pkg.depotd' becomes 'pkg' as an example.
I also was slightly confused by seeing the line that defines the function as 'covered', but not any part of the function itself in some cases (see client/image.py). I'm assuming that means that the definition was evaluated by python, but the function wasn't executed.
As for the coverage itself, it looks like we're mostly lacking a error case testing.
Other things to note are that we're testing the api for specific functionality, but not testing the cli's exposure of it (case-sensitive search is one of many examples).
The only major concerns I have with client.py are the lack of ssl and proxy testing, and a few usage flags for some of the subcommands.
Thanks for doing this! Cheers, -- Shawn Walker _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
