On Tue, Dec 01, 2009 at 04:26:48PM -0600, Shawn Walker wrote:
> Greetings,
>
> The following webrev contains changes and fixes for the following
> issues and RFEs:
>
> 5872 List APIs required
> 12929 image.py:get_publisher_ranks can traceback after older
> client configuration changes
> 12946 pkg list should provide way to list only newest versions of
> all packages
>
> webrev:
> http://cr.opensolaris.org/~swalker/pkg-list/
Only a few comments from me. This looks pretty good.
catalog.py:
- line 504: [nit] Is there any chance you could give this a more unique
name? It's rather hard to search/replace for fmris and actions,
given that we have many variables, objects, and comments with that
name. It's hard to find all of the places where fmris() and
actions() are used with such a common name.
- lines 584/585: Would it be easier to put this check in load(), or
are you trying to save a function call?
api.py:
- Do get_pkg_categories and get_pkg_list need to use the activity
lock? IIUC, it's possible for these functions to download manifests
and we don't want two threads modifying the image at the same time,
correct?
Thanks,
-j
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
