On Tue, Dec 01, 2009 at 06:20:35PM -0600, Shawn Walker wrote: > >api.py: > > > > - Do get_pkg_categories and get_pkg_list need to use the activity > > lock? IIUC, it's possible for these functions to download manifests > > and we don't want two threads modifying the image at the same time, > > correct? > > It's possible that they could indirectly trigger a manifest > retrieval, but I didn't think it strictly necessary to have an > activity lock for them otherwise. > > I'm willing to put one in if you're concerned about transport.
I was actually concerned about the files in the image. The transport should be okay, modulo some locking changes that I need to make. When I added the transport lock, there's an edge case that I missed -- multiple concurrent fileobj reads. That's just a matter of passing the lock to the fileobj, so it's not something I'm worried about for this particular case. I'm not certain what the right answer is for the activity lock, but I thought I would ask, since it seemed hypothetically possible that an image modification might occur. -j _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
