On Wed, Dec 02, 2009 at 02:55:00PM -0800, Brock Pytlik wrote: > If the bug was that mxfr might never get set to false, then this > LGTM. If not, then I didn't understand the fix and I'll have to try > again.
Yes, essentially. The mxfr object keeps track of what was requested for the transfer. When a manifest is successfully downloaded, it's removed from the object. When all manifests are successfully downloaded, the object is empty and returns false. The other code escapes from this loop by raising an exception once we've hit the maximum number of retries. Since this code doesn't retry, and doesn't raise an exception on transient failures, it was looping indefinitely. > One question, is namelist likely to be short, or might it be several > hundred, or several thousand members long? This depends entirely on how many packages are being installed. If you're installing one package, it'll have one item. If you're installing slim_install, it'll have about 650 items. -j _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
