I have respun the webrev, http://cr.opensolaris.org/~padraig/ips-12962-v2/.

It does not address the issue Shawn raised below but does addresses issues which were raised in private emails.

These issues are:
1) The layout of Modify Publisher dialog was bad when running in larger font size, e.g. 14 or 20. 2) Some of the text in the dialogs needed to be changed. The most notable change is that all references to URL were changed to URI.

Padraig

On 12/05/09 21:42, Shawn Walker wrote:
Padraig O'Briain wrote:
Here is an updated webrev http://cr.opensolaris.org/~padraig/ips-12962-v1/

It does not make any changes to the logic but does make some layout changes:

1) Change heading in Manage Publishers dialog
2) Add icons to Up and Down buttons
3) Remove origins expander in Modify Publisher dialog
4) Some minor layout changes in Manage Publishers and Modify Publisher dialog.

This is beautiful. This is the absolute best the manage publishers stuff has ever looked.

However, I did notice that it allowed me to add SSL information to one of my publishers despite one of my origins being http.

Otherwise, this is great!

Cheers,
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to