Padraig O'Briain wrote:
On 12/05/09 21:42, Shawn Walker wrote:
Padraig O'Briain wrote:
Here is an updated webrev
http://cr.opensolaris.org/~padraig/ips-12962-v1/
It does not make any changes to the logic but does make some layout
changes:
1) Change heading in Manage Publishers dialog
2) Add icons to Up and Down buttons
3) Remove origins expander in Modify Publisher dialog
4) Some minor layout changes in Manage Publishers and Modify
Publisher dialog.
This is beautiful. This is the absolute best the manage publishers
stuff has ever looked.
However, I did notice that it allowed me to add SSL information to one
of my publishers despite one of my origins being http.
Otherwise, this is great!
Cheers,
I need to clarify what validation ought to be done here. Some questions.
Are we allowed to mix http and https in origins and mirrors or must they
all be the same type as the URI for the selected repository for the
publisher?
The user is allowed to mix them.
Your comment states that if one of the origins are http then SSL
information should not be specified. This suggest that one can mix
http and https in origins.
Correct.
The code which deals with adding SSL information is __update_ssl_creds.
This code ignores the specified the SSL key and cert if the URI for the
selected repository for the publisher is http. Is this the correct
behavior?
Yes; it should set the SSL Key/Cert to None for all URIs if one of them
is http once the user has clicked OK.
Should we prevent the specification of SSL key and cert if the URI for
selected repository for the publisher is http?
That's up to you, given the above. What the CLI does is if a user adds
an http URI, it automatically removes all SSL Cert/Key information.
Since this is the GUI and your target audience is different, I suggest a
better path.
I don't know what the behaviour should be here, so I'll leave it up to you.
All I care about is the end result:
* users can mix http/https URIs for mirrors and origins
* SSL Key/Cert information will be set to None if http mirrors or
origins are present when the user clicks 'OK' to save the publisher
configuration
Cheers,
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
