Danek Duvall wrote:
- line 1333: it took me forever to see that "or" here meant "obsolete or
renamed". A quick comment might be nice.
Done.
- line 1334: no need for .keys()
Okay.
- line 1344-1349: or_pkgs_per_con.setdefault(cons, {})[pkg] = ver_string
Nice. I'm all for replacing 6 lines with 1 (and it's even readable).
- line 1438-1440: for name in or_pkgs_per_con.get(cons, {}):
Also needed the following line to:
1427 + version = or_pkgs_per_con[cons][name]
as "packages" now no longer exists.
- line 1443: no need for the backslash
Okay.
New webrev at:
http://cr.opensolaris.org/~richb/pkg-5779-v5/
Thanks!
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
