On Fri, Dec 11, 2009 at 08:04:46PM -0800, Brock Pytlik wrote:
> Webrev: http://cr.opensolaris.org/~bpytlik/ips-dep_tests-v1/
I'm not really an expert on this code, so I just have a few nits.
flavor/base.py:
- line 212: Can this be written as "if p" instead?
flavor/depthlimitedmf.py:
- lines 131-134: It would be better to do this using a table-lookup
mechanism, that way you can plug in additional versions without
modifying this code.
variant.py:
- line 216: What would cause self to be False here?
-j
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
