On Fri, Dec 11, 2009 at 10:33:19PM -0600, Shawn Walker wrote:
> webrev
> ======
> http://cr.opensolaris.org/~swalker/pkg-license/
client.py:
- There are a bunch of places where you've changed the code to
collect the return value from api_prepare. I've touched this
function as well, in 13199, to remove the verbose argument. Make
sure to remove the verbose argument from this line when you merge
with my changes.
api.py:
- line 696: You need to grab the cancel lock before changing the state
of can_be_canceled.
- get_licenses():
- Should this be in ImagePlan, since it's an ImagePlan level
manipulation?
- Using get_remote_opener is the most troublesome way to download
these actions. This calls get_datastream(), which returns a
file-object to the caller. You'll be reading the license one URL
at a time. This code also needs to catch and wrap TransportError,
as the transport can't catch its own exceptions when the caller is
performing the read instead of the transport. This approach also
doesn't retry if there's a failure.
IMO, it would be easier to use the MFile/get_files() approach that the
transport currently uses for files and licenses, but just perform
the license download first. Then you would always have a local
copy of the license available, unless the download was unable to
find a copy of the license at any of the hosts.
-j
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
