[email protected] wrote:
On Tue, Dec 15, 2009 at 04:43:07PM -0600, Shawn Walker wrote:
full updated webrev:
http://cr.opensolaris.org/~swalker/pkg-license-2/
...
- lines 137-160: The transport should already create an opener for files
that it has successfully downloaded using the MFile interface. This
code should be simplified to check if the action's data attribute
exists and is callable. If it is, then that's the opener this call
should return. Otherwise, the license has already been installed
and you can create a local opener.
The only thing about that is that I have to wrap the opener again with
another opener since the data returned by that callable is gzip
compressed (I hope always).
I would avoid using the remote_opener under any circumstances, since
it is not robust and can cause the client to fail from a variety of
transport errors.
Just as a point of reference, we were already using remote_opener before
with the info() api call.
Cheers,
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
