Hi Shawn,
Here is the new code review with the changes you
suggested. I moved the method
get_pkg_cat_data out of PackageInfo class into the api_common.py module.
http://cr.opensolaris.org/~rajkumar/cr-12852update2/
regards,
Rajkumar
Shawn Walker wrote:
Rajkumar Srinivasan wrote:
Hi Shawn,
Here is the new code review which is re-merged to gate.
http://cr.opensolaris.org/~rajkumar/cr-12852update1/
Although duplicated code may seem like something to avoid, it really
isn't desirable to expose the get_pkg_cat_data() method to clients.
Because get_pkg_cat_data() is a standalone function, there is really
no need to make it part of the PackageInfo class. Instead, I would
simply move it to the bottom of the api_common.py file and rename it
"_get_pkg_catalog_info" (note the single, leading underscore).
That will allow you to share the function still, but without directly
exposing it to clients. Please also add a docstring to the function
stating that it is a private function and not intended for external
consumers.
Otherwise, this looks very good.
Cheers,
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
