Rajkumar Srinivasan wrote:
Hi Shawn,
Here is the new code review with the changes you suggested. I moved the method
get_pkg_cat_data out of  PackageInfo class into the api_common.py module.

http://cr.opensolaris.org/~rajkumar/cr-12852update2/

src/modules/server/api.py:
line 106: this needs to be changed to the following since the catalog method is a generator: return iter(((), {}))

Otherwise, I think these changes are right, but we're getting ready to close the gate for build 130 and these need to go in after that.

Thanks,
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to