Danek Duvall wrote:
Brock Pytlik wrote:
http://cr.opensolaris.org/~bpytlik/ips-13485-v1/
frmi.py:
- line 302: let's call this "remove_publisher" and put this up with
set_publisher().
Sure
indexer.py:
- It could just be a slow brain, but this modifies the fmris in the
catalog itself, right? Wait, fmris() uses the old catalog file, so how
does this work at all?
From catalog.py, the comment from the fmris function says:
A generator function that produces FMRIs as it iterates over the contents of
the catalog.
So, I think it's still perfectly valid... If it's not then shouldn't it
be removed from the catalog module and an equivalent replacement
possibly provided? As I don't have my head totally around the catalog
code, I'll defer to Shawn's opinion on whether or not this function is
still valid to call.
fmris calls __parse_entry which creates a new pkg fmri and returns it.
Now, if there's a concern that we're caching these implictly somehow or
using a singleton pattern with them, I can have what will be called
"remove_publisher" return a copy of the fmri with the publisher removed,
but unless something fancy is going on under the covers, I don't see the
concern here.
Brock
Danek
_______________________________________________
pkg-discuss mailing list
pkg-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
