On 01/ 5/10 01:04 PM, Danek Duvall wrote:
Brock Pytlik wrote:

http://cr.opensolaris.org/~bpytlik/ips-13485-v1/

frmi.py:

   - line 302: let's call this "remove_publisher" and put this up with
     set_publisher().

Agree.

indexer.py:

   - It could just be a slow brain, but this modifies the fmris in the
     catalog itself, right?  Wait, fmris() uses the old catalog file, so how
     does this work at all?

fmris() doesn't use the "old catalog file". Confusion here? Ignore server/catalog.py; it isn't used here at all. We have a bug open to clean this up. The server only uses modules/catalog.py; same as the client now. server/catalog.py is only used in specific cases where we are upgrading a repository to v1 or for a client communicating with a v0 repository.

The changeset here looks fine otherwise.

Cheers,
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
pkg-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to