You know what else you ought to do... (Kidding, just kidding. I
swear.) :-P
This works for me. Thanks again.
--joanie
On Thu, 2010-01-14 at 14:44 +0000, John Rice wrote:
> Thanks Padraig and Joanie,
>
> Fixed the pylint.
>
> Changed a string so we can implement Michal's suggestion (13887) next
> week by taking the URI out of the translated portion. We are then free
> to put this into a button without impacting l10n next week.
>
> 5689: dmsg = _("Please let the developers know about this problem
> by\n"
> "filing a bug together with the error details listed
> below at:")
> dmsg += "\n\nhttp://defect.opensolaris.org";
>
>
> Changed per Joanie's feedback, we always clear the notify icon if you
> bring up the logs and an error has been logged.
>
> def __on_log_activate(self, widget):
> if self.error_logged:
> self.error_logged = False
> self.w_infosearch_frame.hide()
>
> def __on_infosearch_button_clicked(self, widget):
> if len(self.current_repos_with_search_errors) > 0:
> self.__handle_api_search_error(True)
> return
> if self.error_logged:
> self.__on_log_activate(None)
>
> http://cr.opensolaris.org/~jmr/pm_13333_log_view_14Jan_240pm/
> 13333 PM Provide user notification when errors written to log in GUI.
>
> JR
>
> Padraig O'Briain wrote:
> > pylint reports that some lines in packagemanager.py are too long.
> > Otherwise looks good to me.
> >
> > Padraig
> >
> > On 01/14/10 12:47, John Rice wrote:
> >> Joanie - thanks for the feedback. I have fixed the issues below and
> >> this now supports logging from PM, PM-webinstall and UM. I have
> >> reviewed the code with Padraig offline.
> >>
> >> I have put in #DEBUG for PM, WI and UM for ease of testing. I'll take
> >> them out for final submission to the gate.
> >>
> >> http://cr.opensolaris.org/~jmr/pm_13333_log_view_14Jan_1230pm/
> >> 13333 PM Provide user notification when errors written to log in GUI.
> >>
> >> JR
> >>
> >>
> >>> Having uncommented those lines:
> >>>
> >>> 1. Nit: It seems that the accessible name for that icon is always
> >>> 'Remote search error' regardless if it is a search error or the result
> >>> of the log error. While you could change the AtkObject's name at the
> >>> same time you change the tooltip text, I'd imagine it would be a lot
> >>> simpler to just change the AtkObject's name to something more generic
> >>> like "Error". Would you mind doing so?
> >>>
> >> Done
> >>> 2. Any chance you're making GUI changes outside of the main thread?
> >>> If I
> >>> do the following:
> >>>
> >>> - Uncomment the lines above
> >>> - Enable AT support (logging out if it wasn't already enabled)
> >>> - Launch Accerciser
> >>> - Launch PM
> >>>
> >>>
> >> I was making some gui calls mea culpa :) Tested with Orca and working
> >> fine for me now.
> >>> I can regularly (though not 100% of the time) hang my desktop. Without
> >>> your patch I'm not seeing this issue. Sorry....
> >>>
> >>> Take care.
> >>> --joanie
> >>>
> >>>
> >>
> >> _______________________________________________
> >> pkg-discuss mailing list
> >> [email protected]
> >> http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
>
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
