Mark J. Nelson wrote:
Folks on pkg-discuss: this is how we plan to use the functionality I sent a review request on pkg-discuss for a few moments ago.The bugs: 11127 need to handle export build 13565 nightly mail_msg shouldn't contain manifest build output 13932 package makefiles should not contain package metadata The webrevs: http:/cr.opensolaris.org/~mjnelson/webrev.pkgmetadata/ http://cr.opensolaris.org/~mjnelson/webrev.pkgmetadata.manifests/
My caveat: I'm really quite ill and haven't managed a terribly coherent or thorough review. But, I'd rather see this go back than wait on me since we still have a full workspace code review to go, and I'll also be in there again soon so may have more comments then.
- Yes, the consolidation dependency should be in the transforms. I just hadn't gotten around to doing it, so thanks. - Comments in the makefile are good, again thanks. - I'm not at all convinced that we want any incorporation at all for the 'extra' packages. But, I can't articulate well why right now. - For the depend-on-incorporation, I was thinking pkgmogrify would get a directive that said "if you see this pattern, *add* this new action" rather than transform the existing action. (Multiple matches would just add multiple of the same new action.) - Extensive shell syntax in the makefile does make me nervous. What about users who use csh and its derivatives? That's it so far. liane _______________________________________________ pkg-discuss mailing list pkg-discuss@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
