Thanks Padraig,

Padraig O'Briain wrote:
In installupdate.py a memory error can also be EnvironmentError with errno set to ENOMEM.
Should you also handle this?
I can't get at the errno from the exception at this point I just have a traceback. If its from an EnvironmentError and it will just be surfaced as an Unexpected error.

Is there a risk that you will not have the memory available to display the memory error?
Yep - I will catch this when trying to display the dialog and as a fall back just print the message, if the user is running from the terminal they will see it, if not there is little we can do.

New webrev:
http://cr.opensolaris.org/~jmr/pm_8424_pm_out_of_memory_20Jan_550pm
8424 GUI should use error handler for out of memory conditions

JR

Padraig

On 01/20/10 16:07, John Rice wrote:
Hi - now that we have the global error handler in the GUI this webrev can handle out of memory errors using the misc error message.

The only problem with using this CLI message is that it has hard coded '\n' so it messes up the formating in the dialog. As Danek has mentioned we need to address sharing error messages between the clients, part of this will be parameterizing things like these hard coded '\n' so the CLI can insert them as required and the GUI can ignore them by inserting "". This won't happen for 2010.03.

http://cr.opensolaris.org/~jmr/pm_8424_pm_out_of_memory_20Jan_4pm
8424 GUI should use error handler for out of memory conditions

JR
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to