Ah apologies Padraig hadn't regenerated the webrev.
http://cr.opensolaris.org/~jmr/pm_8424_pm_out_of_memory_21Jan_1250pm
8424 GUI should use error handler for out of memory conditions
JR
Padraig O'Briain wrote:
I am still getting pylint warnings with this webrev.
Padraig
On 01/21/10 11:24, John Rice wrote:
Thanks Padraig, new webrev addressing the issues below:
http://cr.opensolaris.org/~jmr/pm_8424_pm_out_of_memory_21Jan_1120am
8424 GUI should use error handler for out of memory conditions
JR
Padraig O'Briain wrote:
In __display_memory_err should the try at line 5793 be at line 5789?
Did you mean msg_stipped or msg_stripped?
This webrev generates pylint warnings
Padraig
On 01/20/10 17:50, John Rice wrote:
Thanks Padraig,
Padraig O'Briain wrote:
In installupdate.py a memory error can also be EnvironmentError
with errno set to ENOMEM.
Should you also handle this?
I can't get at the errno from the exception at this point I just
have a traceback. If its from an EnvironmentError and it will just
be surfaced as an Unexpected error.
Is there a risk that you will not have the memory available to
display the memory error?
Yep - I will catch this when trying to display the dialog and as a
fall back just print the message, if the user is running from the
terminal they will see it, if not there is little we can do.
New webrev:
http://cr.opensolaris.org/~jmr/pm_8424_pm_out_of_memory_20Jan_550pm
8424 GUI should use error handler for out of memory conditions
JR
Padraig
On 01/20/10 16:07, John Rice wrote:
Hi - now that we have the global error handler in the GUI this
webrev can handle out of memory errors using the misc error message.
The only problem with using this CLI message is that it has hard
coded '\n' so it messes up the formating in the dialog.
As Danek has mentioned we need to address sharing error messages
between the clients, part of this will be parameterizing things
like these hard coded '\n' so the CLI can insert them as required
and the GUI can ignore them by inserting "". This won't happen
for 2010.03.
http://cr.opensolaris.org/~jmr/pm_8424_pm_out_of_memory_20Jan_4pm
8424 GUI should use error handler for out of memory conditions
JR
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
