On 01/22/10 07:43 PM, [email protected] wrote:
Offline, I recieved some additional code review from Dan. This included
some changes to the api to support __enable_cancel instead of making
each caller grab the cancel lock and set can_be_canceled. I also
changed NRLock to throw an exception instead of raising an assertion.
This way, even if assertions are disabled the NRLock code is still
non-reentrant.
The new webrev is here:
http://cr.opensolaris.org/~johansen/webrev-3720-3/
modules/client/api.py:
line 141: two spaces after '='
line 1537: s/in //
line 1772: does this need to be wrapped with try:/finally:
activity_lock.release() in case enable_cancel fails? Likewise, it looks
like if an exception happens in several spots in here that the activity
lock may not be released.
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
