On Sat, Jan 23, 2010 at 04:26:03PM -0600, Shawn Walker wrote: > >http://cr.opensolaris.org/~johansen/webrev-3720-3/ > > modules/client/api.py: > line 141: two spaces after '='
Fixed. > line 1537: s/in // Fixed. > line 1772: does this need to be wrapped with try:/finally: > activity_lock.release() in case enable_cancel fails? This is a generator function. I didn't see a tidy way to wrap this in another function with try/finally and have things work correctly. Enable_cancel can't fail unless there's an assertion failure. My understanding is that these should propogate to the top and cause a traceback. I don't think we need to worry about that particular case here. > Likewise, it looks like if an exception happens in several spots in > here that the activity lock may not be released. Which spots? I went through this code pretty carefully to catch the places where it looked like there might be an uncaught exception. If you think I've missed one or more, would you please provide specifics? Thanks, -j _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
