On Mon, Jan 25, 2010 at 04:28:53PM -0800, Danek Duvall wrote: > The webrev > > http://cr.opensolaris.org/~dduvall/pkg-consolidate/
In general this looks good. I have a meta-comment about the code in imageplan around line 641. I'm assuming that the action order doesn't have to be deterministic, but it just cannot change during the remainder of the evaluate step. While this isn't a problem now, we might want to observe that adding install actions, or changing the order of the actions in the package plan after this point will lead to very confusing and hard to debug results. -j _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
