Danek Duvall wrote:
Brock Pytlik wrote:
imageplan.py
612: I know this isn't your comment but can you explain how/where the
reference counting is going on here?
I guess what's there is pretty straightforward to me -- we're removing the
action deletion if the symlink is in the final image. I could rewrite the
comment to essentially reorder the two lines:
# Implement link reference counting by eliminating link removal plans
# if the link is in the final image.
Ok, I think I know what tripped me up was that I forgot that directories
were also being reference counted. I saw the same pattern repeated but
couldn't figure out why this was special about doing reference counting
in the link case but not the dir case. I get it now. I also don't have a
clear suggestion about how to rewrite the comments to clear things up,
so it was probably just my not groking the entire process when I read
the comment.
649-650: Is there a missing word? "the newly discovered update
ActionPlans" doesn't read right to me.
No, that's right. They're update ActionPlans which have newly been
discovered: ((newly discovered) (update ActionPlans))
Ah. I think I was missing that update ActionPlans was a entity unto
itself. On reflection, this makes sense.
697: couldn't nkv[1] be replaced with keyval?
Yep, done.
Thanks,
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
