Thanks for all the feedback and suggestions. I've tried to accomodate as many of them as possible today:
sch - -F tsv is now the way to generate parseable output various - -H is not enforced by -F I've also tried to address Danek's feedback about minimising the special processing required for different output formats. I've re-generated the webrev at the same location and re-tested all the changes. Webrev: http://cr.opensolaris.org/~garypen/gate/ I still need to address: sw - Add unit test I'm not going to have time to address this before putback, perhaps I can file a bug and address it later? Gary On Wed, Jan 27, 2010 at 12:36:21PM +0000, Gary Pennington wrote: > Hi, > > (I'm hoping to get these changes in b132 to help on-ips work with zones) > > Webrev: > > http://cr.opensolaris.org/~garypen/gate/ > > bash-4.0$ hg comment > 12738 zone install/attach incorporation logic needs enhancement > 14053 pkg brand creation potentially broken with new publisher data > > The change to client.py is probably most controversial. I've introduced > a (very simple) parseable output mode for the publisher sub-command so > that I can access the information easily when installing zones. > > The guiding principles are: > > - produce output that standard unix text processing tools can process > - assume that repetition of redundant data to support line-oriented > reporting is fine > - don't print headers when using parseable mode > - assume that "something better" is coming along in the future and this > approach is good enough for now > > Example outputs: > > gary...@osol:~$ pkg publisher > PUBLISHER TYPE STATUS URI > opensolaris.org (preferred) origin online > http://pkg.opensolaris.org/dev/ > opensolaris.org (preferred) mirror online > http://pkg-na-2.opensolaris.org/dev/ > osol (non-sticky, disabled) origin online > http://192.168.2.100:10000/ > > gary...@osol:~$ pkg publisher -p > opensolaris.org true true true http://pkg.opensolaris.org/dev/ > origin online > opensolaris.org true true true > http://pkg-na-2.opensolaris.org/dev/ mirror online > osol false false false http://192.168.2.100:10000/ origin online > > gary...@osol:~$ pkg publisher -pn > opensolaris.org true true true http://pkg.opensolaris.org/dev/ > origin online > opensolaris.org true true true > http://pkg-na-2.opensolaris.org/dev/ mirror online > > The changes to common.ksh and pkgcreatezone are less controversial and take > advantage of this new output option to fix the two bugs. > > I'd like to make this change available to everyone using the pkg command, > but I would agree if it made more sense to make this option project > private and undocumented given the time pressure against the 132 deadline. > > Gary > _______________________________________________ > pkg-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/pkg-discuss -- Gary Pennington Solaris Core OS Sun Microsystems [email protected] _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
