On Thu, Jan 28, 2010 at 01:43:08PM -0600, Shawn Walker wrote:
> On 01/28/10 01:17 PM, Gary Pennington wrote:
> >I've removed the code that ensures headers and data are aligned in TSV
> >format. I've re-generated the webrev at the same location.
>
> src/client.py:
>
> line 2512: Not quite right: s/( "tsv" )/("tsv",)/
>
> lines 2515-2522, 2525-2526: line continuation indentation is 4
> spaces; please don't align subsequent lines with the opening; generally
> speaking, we use PEP8 python formatting
>
> lines 2536-2539: this can be simplified to: return "default" in record[0]
>
> lines 2542-2545: simplified as above: return "tsv" in record[0]
>
> line 2568: Despite my predilections toward non-American English
> spelling, the pkg(5) project uses US English spelling:
> s/recognised/recognized/
>
> In addition, this is a usage error, not a normal error, so instead of
> using error() use usage().
>
> line 2571: s/publisher_list/publisher/
>
> lines 2684, 2686, 2688, 2690, 2692, 2694: needs _(); this should be
> fine since the zone scripts use LC_ALL=C
>
> line 2702: missing '.'
>
> lines 2708-2711, 2721-2723: line continuation indent is 4 spaces
>
Thanks.
All done. Tested. webrev re-generated.
> You really should have a unit test for the publisher output before
> putback, but I leave that to you and Danek to decide.
>
I understand that, but I don't have time to write it before the b132
deadline and this support will help on- ips to work well with zones.
Thanks,
Gary
> Cheers,
> --
> Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
