On 02/ 3/10 05:28 PM, [email protected] wrote:
Hi Shawn,
On Wed, Feb 03, 2010 at 03:20:01PM -0600, Shawn Walker wrote:
Greetings,
The following webrev contains fixes for the following issues:
11522 pkg should require publisher prefix to match repository information
7156 client image api needs image creation interface
12744 update_publisher over-zealously testing publisher validity
14203 image-create usage doesn't mention mirror / origin options
webrev:
http://cr.opensolaris.org/~swalker/pkg-11522/
Most of this looks fine to me. The only comments I had pertain to the
api and transport.
...
api_errors.py:
- lines 1249-1256: I believe this exception is redundant.
UnsupportedRepositoryOperation is what the Transport currently uses
when it cannot find any repositories from the requested publisher
that support a particular operation.
Yes and no. I originally had it as a subclass of
UnsupportedRepositoryOperation but that's not quite right for a few reasons:
* it also gets raised when a repository supports the operation but
doesn't provide any configuration information)
* it doesn't use the additional arguments normally passed to
UnsupportedRepositoryOperation
I suppose the other option here would be to raise both exceptions
separately, but I'm not really happy with either direction; suggestions
are welcome.
transport/transport.py:
- Does your code use both get_publisherdata and get_publisherinfo?
At the moment, I'm only using the get_publisherdata(); I reserved
get_publisherinfo() for later. One's to get the raw information and the
other is to get the processed information.
Cheers,
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
