On Thu, 2010-02-04 at 16:59 -0600, Shawn Walker wrote: > On 02/ 4/10 04:55 PM, Joanmarie Diggs wrote: > > Hi Shawn. > > > > This seems to have implications for GUI users, beyond last-minute > > i18n/l10n. In particular, the current Add Publisher dialog's > > instructions are to "Specify the publisher name and URI" -- and you have > > to specify a name in order to add the publisher. Given that you must now > > also get the publisher name right, presumably this entry and the > > corresponding instructions should be removed. Otherwise, you're just > > setting the user up for a confusing experience. > > The name was already required to match before this change, the only > difference now is that an exception gets raised properly and the user > actually gets to see an error message telling them as such.
Really? I guess I'm missing something.... Without your webrev I can type 'contrib' in the Name entry, http://pkg.opensolaris.org/contrib in the URI entry and press the Add button to successfully add contrib. With your webrev doing the above results in a Publisher error dialog whose text tells me that: One or more of the repository origin(s) listed below contains package data for contrib.opensolaris.org; not contrib: This is either because one of the repository origins is not valid for this publisher, or because the publisher configuration retrieved from the repository origin does not match the client configuration. If there's only one correct name, insisting that the user provide it without knowing what it is, and then presenting the user with an error dialog which might take the user a couple reads to conclude that this is what has occurred is not the most ideal user experience IMHO. I think it would be better if the user were not prompted for a name in this case. > ... > > > I presume that programmatically detecting now-erroneous names and > > changing them every place it matters is not doable. But if I'm wrong > > about that, doing so might ease the transition for users who added a > > publisher under a no-longer-valid name and then wanted (or needed?) to > > add a new origin. Otherwise, the only course of action is to remove and > > then re-add the publisher using the correct name (right?) which leads to > > orphaned packages. > > Packages never really get truly orphaned. For example, if your > publisher was named 'dev' and then you later added it (correctly) as > 'opensolaris.org' and removed 'dev', then the next time the solver runs > it will switch affects packages to be installed from 'opensolaris.org' > instead assuming that 'opensolaris.org' offers equivalent packages. This I did not know. Obviously. :-) Very cool. Thanks for that info! --joanie _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
