Hi Shawn,
On Fri, Feb 05, 2010 at 12:48:22PM -0600, Shawn Walker wrote:
> 2nd webrev (full):
> http://cr.opensolaris.org/~swalker/pkg-11522-2-full/
Just a few more nits:
api.py:
- lines 823 - 834: Would it make sense to combine the try/except and
try/finally statements into one try/except/finally block? That
would allow you to have only one call to __activity_lock.release().
Also, in its current incarnation, the block between 823 and 826
needs to differentiate between a CanceledException and the exception
that's raised if the image lock fails. The call to
__disable_cancel() can return a CanceledException so any function
that calls this should wrap this in a try/except, with the
CanceledException handler calling cancel_done().
- line 2123: The e variable doesn't appear to be used here.
- line 2130: It should be safe to remove this line. If a
CanceledException was raised, cancel_done was called on 2124. If
any other exception was raised, cancel_cleanup_exception is called
on 2127. If no exception was raised, cancel is disabled on line
2121.
transport/transport.py:
- line 557: 'url' is being used, but it hasn't been defined.
Thanks,
-j
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
