Thanks for the feedback Joanie, much appreciated as always, comments below:
JR
Joanmarie Diggs wrote:
Hey John.
I just gave this one a try:
On Fri, 2010-02-05 at 14:26 +0000, John Rice wrote:
Updated patch attached, with some comments from Michal incorporated.
Again this needs to be applied on top of Shawn's patch:
http://cr.opensolaris.org/~swalker/pkg-11522/
This is definitely much better over what I was seeing last night. Thank
you!
Great.
P.s. Joaine, I don't think you can trigger this from the modify dialog
anymore, as you will always have a valid pub added in the first place,
but feel free to show me the errors of my ways :)
Well, technically speaking, you are correct. :-P Whereas before I was
seeing Shawn's error message, I'm now seeing this traceback:
Ah I knew you'd find me out, no worries, I'm out until Wednesday, but
Michal can modify the webrev to handle this cleanly.
Error details:
Traceback (most recent call last):
File "/usr/lib/python2.6/vendor-packages/pkg/gui/repository.py", line
1566, in __show_errors
error_msg += str(err[1])
File "/usr/lib/python2.6/vendor-packages/pkg/client/api_errors.py",
line 1187, in __str__
if len(self.location) > 0:
TypeError: object of type 'RepositoryURI' has no len()
In order to get to that point, what I had to do is:
1. Use PM to add contrib as a publisher using the name 'contrib'
2. Apply Shawn's webrev and your webrev
3. Use PM's Modify Publisher dialog to add the following new origin
to contrib: http://pkg-na-2.opensolaris.org/contrib
* a publisher already exists with one of the 'known' prefixes
Have pub:
opensolaris.org
http://pkg.opensolaris.org
Add:
oss
http://pkg.opensolaris.org
Get: Successfully Added Dialog
oss (opensolaris.org)
http://pkg.opensolaris.org
So have just changed the alias, we could inform the user that that's
what's happened but not without string changes which we want to avoid.
I think this is fine. In fact, I'd tried this scenario before reading
the full way through this message, and was pleasantly surprised PM just
quietly took care of things.
Great.
The one case where it might be worth informing the user is if the
original publisher was disabled. (Because normally the publishers you
add are enabled by default, which won't be the case here.)
Good point, I'll have a think about it.
But I don't
think this is something worth breaking a string freeze over. Whether or
not PM should assume that the newly "added" publisher in this scenario
should be enabled is something I don't have a strong opinion on....
Likewise
Thanks again. Take care.
--joanie
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
