[email protected] wrote:
On Mon, Feb 08, 2010 at 06:06:12PM -0800, Brock Pytlik wrote:
Webrev:
http://cr.opensolaris.org/~bpytlik/ips-14307-v1/
I think these changes are okay, but I do have a meta comment about the
code that you've added. In particular, it's full of three letter
variables and has no comments. If someone who isn't familiar with our
code stumbles on this routine, they may freak out since it looks like a
big O(N^4) loop that's been obfuscated.
To put this another way: anything you do to improve the readability now
may directly benefit you in the future. I've had to go fix code that I
wrote years ago, only to discover I no longer remember what it's doing.
Ok, I'll throw some more comments in I guess.
I'm not sure how much there is to say except, "do the same thing you
just did, only on the next element which is blah" but I'll give it some
thought.
Brock
-j
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
