Padraig,
This looks fine with two minor comments.
1. Do we need to set and unset busy cursor?
2. In the new *py file we should have "import gnome, etc..." in the
try/catch as in other modules and exit with error value if it's not there.
--
best
Michal Pryc
On 11/02/2010 11:10, Padraig O'Briain wrote:
I have updated the webrev,
http://cr.opensolaris.org/~padraig/ips-14422-v2/,
following feedback from John and Michal.
I now use LOGNAME in packagemanager.py to determine the user who
invoked Package Manager.
I have added exception handling to openlink.py.
Padraig
On 02/11/10 08:51, Padraig O'Briain wrote:
The webrev, http://cr.opensolaris.org/~padraig/ips-14422-v1/, fixes
14422 New Firefox instances is executed as root by packagemanager
This webrev ensures that firefox is launched as the user who invoked
Package Manager instead of root.
Padraig
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
