Reviewed offline with Padraig and tested, looks good to me.
JR
Michal Pryc wrote:
On 11/02/2010 14:09, Padraig O'Briain wrote:
Michal,
On 02/11/10 13:33, Michal Pryc wrote:
Padraig,
This looks fine with two minor comments.
1. Do we need to set and unset busy cursor?
We do not need to do it but it cannot hurt to prevent user
interacting with Package Manager while we are trying to launching
firefox.
2. In the new *py file we should have "import gnome, etc..." in the
try/catch as in other modules and exit with error value if it's not
there.
I have updated the webrev,
http://cr.opensolaris.org/~padraig/ips-14422-v3/.
Padraig
Padraig,
It is fine and it can be commited, but before commiting, please remove
those two lines:
1416 + print "set_busy_cursor"
1432 + print "unset_busy_cursor"
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
