Shawn Walker wrote:
On 02/11/10 10:34 AM, John Rice wrote:
Hi - following webrev fixes a number of issues with unhandled exceptions
that can be raised by the API in particular the ImageLockedError.

http://cr.opensolaris.org/~jmr/14481_image_lock_not_handled_11Feb_425pm/
14481 Package version Info image lock exception not handled
14437 pm traceback in update_all on startup

gui/modules/webinstall.py:
lines 487-492: these are all covered by ApiException, so that's the only thing you need here

Cool will change it.

General:

So one thing that isn't clear to me is how the background threads PM uses to retrieve package information via api_obj.info() work.

Specifically, if it tries to retrieve some package information, and it can't because an ImageLockedError() gets raised (which isn't totally accurate, what's really locked is the ImageInterface because there's another transport operation in progress, but it's effectively the same to consumers), how soon will it retry again or will it just give up completely?
It just gives up, this is a low value operation, if it fails its not catastrophic to the user. We do raise the image lock exception for the user if they are trying to do something such as search, install, remove and so on which is more important to flag directly to them. We are also making judicious use of the busy cursor to try and prevent the user getting into this situation in the first place, such as when you are clicking on a row in the main list view.

JR

Cheers,

_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to