Shawn - did a review offline with Michal on this, I made the change you
suggested. I have also changed how we log the information from api.info
in a few places to make things more consistent.
http://cr.opensolaris.org/~jmr/14481_image_lock_not_handled_11Feb_6pm/
14481 Package version Info image lock exception not handled
14437 pm traceback in update_all on startup
Two issues remain. On checking by running a webinstall for wine, and
playing with Modify Publisher from PM, I can trigger lock errors that
are not handled. So repository.py needs reviewed. Also when hitting
Refresh I get the lock dialog coming up twice.
JR
Shawn Walker wrote:
On 02/11/10 10:34 AM, John Rice wrote:
Hi - following webrev fixes a number of issues with unhandled exceptions
that can be raised by the API in particular the ImageLockedError.
http://cr.opensolaris.org/~jmr/14481_image_lock_not_handled_11Feb_425pm/
14481 Package version Info image lock exception not handled
14437 pm traceback in update_all on startup
gui/modules/webinstall.py:
lines 487-492: these are all covered by ApiException, so that's the
only thing you need here
General:
So one thing that isn't clear to me is how the background threads PM
uses to retrieve package information via api_obj.info() work.
Specifically, if it tries to retrieve some package information, and it
can't because an ImageLockedError() gets raised (which isn't totally
accurate, what's really locked is the ImageInterface because there's
another transport operation in progress, but it's effectively the same
to consumers), how soon will it retry again or will it just give up
completely?
Cheers,
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
