On 02/15/10 07:12 AM, Tim Foster wrote:
Hi everyone,
I've a webrev here that I'd appreciate a code review of:
http://cr.opensolaris.org/~timf/14339-pkgsend
14339 'pkgsend import' fails on System V packages
14554 pkgsend import should generate license actions for SVR4 datastream bundles
There's a lot of change to the two test cases that cover this
functionality: the previous versions of these tests were happily passing
all the time, even in the face of broken code.
The tests now import from SVR4 packages and verify that the files
installed from the package appear on disk correctly (overlapping the pkg
install tests a little). I considered only verifying that the actions
produced by 'pkgsend generate' reflected the SVR4 package contents, but
decided that what I have tests a bit more of the code path.
So modulo Danek's comments:
src/publish.py:
lines 416-419: simplify this to: yield (action, action.name in
nopub_actions)
Cheers,
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
