On 02/23/10 06:22 AM, Tim Foster wrote:
hi all,
I've a fix to pkgsend that I was hoping I could get a code review of
please.
This change makes it gracefully fail when asked to create a repository
using an invalid file URL, and makes it more accommodating when using a
file URL with more '/' characters than are strictly necessary.
14022 traceback when pkgsend create-repository is given a path with too many /'s
http://cr.opensolaris.org/~timf/14022-pkgsend-fileurl
modules/publish/transaction.py:
line 24: s/2009/2010/
line 569: I'd suggest:
"'%s' contains host information, which is not supported for
filesystem operations."
lines 571-576: rather than trying to deal with the four '////' case
specifically, I'd rather see this just try to replace any '/' at the
beginning of the string with a single '/'.
src/publish.py:
line 52: don't import this; see below
line 134: the publication tools are currently not expected to catch
client ApiExceptions, and the publication API is intentionally setup to
completely wrap all errors raised so that callers only catch
TransactionError exceptions. What was the case for this change?
Cheers,
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
