On Wed, 2010-04-14 at 15:19 -0700, Danek Duvall wrote:
> Tim Foster wrote:
>
> > http://cr.opensolaris.org/~timf/14022-pkgsend-fileurl/
>
> transaction.py:
>
> - line 574: I'm not sure I get the mix between "os.path.sep" and "/". I
> think it'd be safe to just use the latter in both places. And please
> use double quotes.
>
> t_pkgsend.py:
>
> - line 247: probably should include "" in this list, too, since
> "file:/path/to/dir" is also legal.
Thanks for the review guys - I've updated the webrev and retested. I'll
put this back tomorrow unless I hear any objections.
cheers,
tim
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
