Hi Shawn, On Tue, 2010-02-23 at 19:54 -0600, Shawn Walker wrote: > 791 stack trace when installing directory or file with missing > mandatory attributes > 1530 file install fails if user is unknown during install > 9632 verify can traceback if group or user is unknown or attribute is > missing
(I'd been chatting to Shawn about a suggested fix in this area) The fix I had involved changes to validate_fsobj_common, but also a check in the __init__ methods for the filesystem objects (which I was uneasy about) for the case where we pass multiple path attributes, resulting in us trying to .lstrip() a list. I was raising an error if isinstance(.., list) Would there be a better way to check for the below case, mentioned in: http://defect.opensolaris.org/bz/show_bug.cgi?id=791#c7 With your patch applied, I still have: t...@linn[775] pkgsend add file /etc/motd path=foobar mode=0644 owner=root group=sys path=baz Traceback (most recent call last): File "/export/home/timf/projects/ips/9632-missing-group-pkg.hg/proto/root_i386/usr/bin/pkgsend", line 553, in <module> __ret = main_func() File "/export/home/timf/projects/ips/9632-missing-group-pkg.hg/proto/root_i386/usr/bin/pkgsend", line 525, in main_func ret = trans_add(repo_uri, pargs) File "/export/home/timf/projects/ips/9632-missing-group-pkg.hg/proto/root_i386/usr/bin/pkgsend", line 207, in trans_add action, lp = pkg.actions.internalizelist(args[0], args[1:]) File "/export/home/timf/projects/ips/9632-missing-group-pkg.hg/proto/root_i386/usr/lib/python2.6/vendor-packages/pkg/actions/__init__.py", line 290, in internalizelist action = types[atype](data=None, **attrs) File "/export/home/timf/projects/ips/9632-missing-group-pkg.hg/proto/root_i386/usr/lib/python2.6/vendor-packages/pkg/actions/file.py", line 61, in __init__ self.attrs["path"] = self.attrs["path"].lstrip("/") AttributeError: 'list' object has no attribute 'lstrip' pkgsend: This is an internal error. Please let the developers know about this problem by filing a bug at http://defect.opensolaris.org and including the above traceback and this message. The version of pkg(5) is '694fd825a62a+'. I can file a separate bug if you'd prefer? cheers, tim _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
