On 03/ 2/10 08:26 PM, Bart Smaalders wrote:
http://cr.opensolaris.org/~barts/14905/
14905 Importer should have an option to ignore packages from one or more
consolidations
14901 need a way to publish timestamps when not using import
2758 pkgsend -T needs a test case
mercurial log comment has two spaces after bug numbers?
src/man/pkgsend.1.txt:
lines 18-20: nit: would be nice to see -T first as other subcommands
line 23: did you really intend to show [ -T pattern ] twice? On line
73, you have it as '[-T pattern] ... bundlefile ...'
src/publish.py:
line 44: unused import?
lines 90-99: would be nice to see options in same order as that in
man page
line 240: stray newline?
line 307: s/lets/leaves/
line 308: s/valud/valid/
lines 306-327, 418-439: logic seems identical, could be shared in a
function to ensure that if it gets changed in the future both places are
affected?
line 329: 'action' variable isn't defined here; maybe 'a' instead?
line 348: not used
lines 282, 402: not your changeset, but stray semicolon?
lines 490-496: not your changeset, but one tabstop too many?
src/tests/cli/t_pkgsend.py:
line 35: unused import
line 690: > 80 characters?
line 700: missing ' ' after second ','
line 715: stray newline?
src/util/distro-import/importer.py:
line 1250: not used
line 1287: missing "global curpkg" ? (see lines 1532-1567)
line 1638: not using delivered_via_ips() purposefully?
Cheers,
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
